fix: broken code embedding #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonzshik
reviewed
Mar 4, 2025
conceptual/Npgsql/types/basic.md
Outdated
| @@ -66,7 +66,7 @@ multirange types (PG14) | NpgsqlRange\<TElement>[] | | |||
| enum types | TEnum | | |||
| array types | Array (of element type) | | |||
|
|
|||
| <sup>1</sup>Types which can be read as `byte[]` can also be written as `ReadOnlyMemory<byte>` and `Stream`., and if they could be big, consider using `Stream`CommandBehavior.SequentialAccess` and `NpgsqlDataReader.GetStream()` to stream the row and column instead of buffering them. Note that if you're reading string data (e.g. `jsonb`) as binary, it's you're responsibility to perform UTF8 decoding (or whatever encoding is configured for your database). | |||
| <sup>1</sup>Types which can be read as `byte[]` can also be written as `ReadOnlyMemory<byte>` and `Stream`., and if they could be big, consider using `StreamCommandBehavior.SequentialAccess` and `NpgsqlDataReader.GetStream()` to stream the row and column instead of buffering them. Note that if you're reading string data (e.g. `jsonb`) as binary, it's you're responsibility to perform UTF8 decoding (or whatever encoding is configured for your database). | |||
There was a problem hiding this comment.
It probably should have been just CommandBehavior.SequentialAccess and Stream there is wrong. Also, there seems to be an unnecessary . after the first Stream.
There was a problem hiding this comment.
And another, in the last sentence you're should have been your.
There was a problem hiding this comment.
Oh yeah, you're right. I changed those things as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this code embed was formerly closed too early and therefore it messed up some styling.