Fix install-strategy=linked package name for workspace packages + workaround for another bug #8096
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know whether this fix should be limited to `workspaceProxy()` or whether I was correct in placing it in `assignCommonProperties()`.
xkr47
changed the title
xkr47
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #6122.
I don't know whether the
packageNametonamepropagation should be limited toworkspaceProxy()or whether I was correct in placing it inassignCommonProperties(). It is based on similar code I found elsewhere.Also had to add a fix/workaround for
this.idealTree.children.getbeing undefined/null sometimes when runningnpm install. Haven't got the slightest clue why.Additional tests not yet done, requires some test code refactoring to support workspace packages having names not matching their directory name..
Works for me (TM). You can try these changes out locally by implementing the same changes in the files in
<your_node_installation_root>/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/.References
Fixes #6122