[Discover] Fix suggestions for ES|QL charts (elastic#197583)

Fixes elastic#197342 In this PR (elastic#197101) I removed the legacy metric from being suggested in the suggestion panel, and replaced it with the new metric visualization. To maintain the previous behavior in Lens (suggesting a new metric in the same place as legacy metric), we made the score higher for the new metric. This positioned it higher also in the Discover ESQL suggestions. This led to an issue where one expected suggestion didn’t appear because we only display the top 6 suggestions by score and it got pushed out by metric. Additionally, I made a change here to only display the metric without bucketed columns in the suggestion panel. I don't see there's a lot of value in suggesting bucketed metric unless it's something user chooses intentionally. Should be merged to 8.x after this: elastic#197337
nreese · Oct 25, 2024 · b3b85da · b3b85da
1 parent 0ff9a8a
commit b3b85da
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 14 deletions.
diff --git a/test/functional/apps/discover/group3/_lens_vis.ts b/test/functional/apps/discover/group3/_lens_vis.ts
@@ -110,8 +110,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     return seriesType;
   }
 
-  // Failing: See https://github.com/elastic/kibana/issues/197342
-  describe.skip('discover lens vis', function () {
+  describe('discover lens vis', function () {
     before(async () => {
       await security.testUser.setRoles(['kibana_admin', 'test_logstash_reader']);
       await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
@@ -616,8 +615,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       expect(await getCurrentVisTitle()).to.be('Pie');
       await testSubjects.existOrFail('partitionVisChart');
 
-      await discover.chooseLensSuggestion('barVerticalStacked');
-      await changeVisShape('Line');
+      await discover.chooseLensSuggestion('waffle');
+      await changeVisShape('Treemap');
 
       await testSubjects.existOrFail('unsavedChangesBadge');
       await discover.saveUnsavedChanges();
@@ -626,8 +625,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await discover.waitUntilSearchingHasFinished();
 
       await testSubjects.missingOrFail('unsavedChangesBadge');
-      expect(await getCurrentVisTitle()).to.be('Line');
-      await testSubjects.existOrFail('xyVisChart');
+      expect(await getCurrentVisTitle()).to.be('Treemap');
+      await testSubjects.existOrFail('partitionVisChart');
     });
 
     it('should close lens flyout on revert changes', async () => {

diff --git a/x-pack/plugins/lens/public/visualizations/metric/suggestions.test.ts b/x-pack/plugins/lens/public/visualizations/metric/suggestions.test.ts
@@ -189,7 +189,7 @@ describe('metric suggestions', () => {
               breakdownByAccessor: bucketColumn.columnId,
             },
             title: 'Metric',
-            hide: false,
+            hide: true,
             previewIcon: IconChartMetric,
             score: 0.51,
           },
@@ -221,7 +221,7 @@ describe('metric suggestions', () => {
               breakdownByAccessor: bucketColumn.columnId,
             },
             title: 'Metric',
-            hide: false,
+            hide: true,
             previewIcon: IconChartMetric,
             score: 0.51,
           },
@@ -294,7 +294,7 @@ describe('metric suggestions', () => {
               breakdownByAccessor: bucketColumn.columnId,
             },
             title: 'Metric',
-            hide: false,
+            hide: true,
             previewIcon: IconChartMetric,
             score: 0.52,
           },
@@ -326,7 +326,7 @@ describe('metric suggestions', () => {
               breakdownByAccessor: bucketColumn.columnId,
             },
             title: 'Metric',
-            hide: false,
+            hide: true,
             previewIcon: IconChartMetric,
             score: 0.52,
           },
@@ -357,7 +357,7 @@ describe('metric suggestions', () => {
             breakdownByAccessor: bucketColumn.columnId,
           },
           title: 'Metric',
-          hide: false,
+          hide: true,
           previewIcon: IconChartMetric,
           score: 0.52,
         },

diff --git a/x-pack/plugins/lens/public/visualizations/metric/suggestions.ts b/x-pack/plugins/lens/public/visualizations/metric/suggestions.ts
@@ -30,8 +30,6 @@ export const getSuggestions: Visualization<MetricVisualizationState>['getSuggest
 
   const bucketedColumns = table.columns.filter(({ operation }) => operation.isBucketed);
 
-  const hasInterval = bucketedColumns.some(({ operation }) => operation.scale === 'interval');
-
   const unsupportedColumns = table.columns.filter(
     ({ operation }) => !supportedDataTypes.has(operation.dataType) && !operation.isBucketed
   );
@@ -64,7 +62,7 @@ export const getSuggestions: Visualization<MetricVisualizationState>['getSuggest
     title: metricColumns[0]?.operation.label || metricLabel,
     previewIcon: IconChartMetric,
     score: 0.5,
-    hide: hasInterval,
+    hide: !!bucketedColumns.length,
   };
 
   const accessorMappings: Pick<MetricVisualizationState, 'metricAccessor' | 'breakdownByAccessor'> =