Build improvements #674
Merged
Build improvements #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.config diff.config change: https://github.com/nrfconnect/sdk-sidewalk/actions/runs/13369218477/artifacts/2602663160 Configuration diff too long to fit. Check file in artifacts. |
RobertGalatNordic
approved these changes
Jan 24, 2025
Kconfig.dependencies
Outdated
| @@ -127,6 +180,18 @@ config PSA_WANT_ALG_CBC_PKCS7 | |||
| config PSA_WANT_ALG_HKDF | |||
| default n | |||
|
|
|||
| config PSA_USE_CC3XX_KEY_AGREEMENT_DRIVER | |||
| default n if SOC_NRF52840 || SOC_NRF5340_CPUAPP | |||
There was a problem hiding this comment.
I'm wondering if we could find a more generic reason for the if statement than specific SOC,
I thought that both nrf52 and nrf53 use crypto cell, so maybe this should be unconditionally default to false ? (as nrf54 do should not have and use this config? )
There was a problem hiding this comment.
the nrf crypto configuration is a minefield, I would rather not change this.
Here is the original PR, I just move it #598
ktaborowski
force-pushed
the
build_improvements
branch
from
0c6fbc3 to
7419137
Compare
ktaborowski
force-pushed
the
build_improvements
branch
4 times, most recently
from
49fe672 to
5bfd8f5
Compare
RobertGalatNordic
force-pushed
the
build_improvements
branch
6 times, most recently
from
f838a31 to
168dab5
Compare
ktaborowski
force-pushed
the
build_improvements
branch
from
168dab5 to
57fd88a
Compare
[KRKNWK-15837] Signed-off-by: Krzysztof Taborowski <[email protected]>
[KRKNWK-15837] Signed-off-by: Krzysztof Taborowski <[email protected]>
Move configuration to generic files Signed-off-by: Krzysztof Taborowski <[email protected]>
if logs enalbed and different than minimal Signed-off-by: Krzysztof Taborowski <[email protected]>
fix build isses Signed-off-by: Krzysztof Taborowski <[email protected]>
When Kconfigs are evaluated, the placement is critical. If value is disabled in the sample Kconfig, It takes precedence If on the other hand it is disabled in Sidewalk Kconfig it is eveluated last, and any unconditional default before takes precedence ( and in definition of those configs the default value is set unconditionaly) Signed-off-by: Robert Gałat <[email protected]>
fix test Signed-off-by: Robert Gałat <[email protected]>
ktaborowski
force-pushed
the
build_improvements
branch
from
57fd88a to
81250cc
Compare
totyz
added
func-integration
source
current log thread delay is not sufficient Signed-off-by: Krzysztof Taborowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI parameters
Description
JIRA ticket:
Self review