Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't reject without an error #30

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: don't reject without an error #30

merged 1 commit into from
Jan 29, 2024

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Jan 29, 2024

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Bug fix

Current Behavior

If not connected, the sendCommand will throw without an error.

(Which can cause problems in the catch handlers of consumer code which expects there to be an error)

New Behavior

If not connected, the sendCommand will throw with an error.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@nytamin nytamin requested a review from a team January 29, 2024 07:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5126c34) 51.79% compared to head (c8d9d31) 51.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   51.79%   51.79%           
=======================================
  Files          37       37           
  Lines         863      863           
  Branches      146      146           
=======================================
  Hits          447      447           
  Misses        363      363           
  Partials       53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/hyperdeck.ts Show resolved Hide resolved
@nytamin nytamin merged commit 01f0d4f into master Jan 29, 2024
12 of 14 checks passed
@nytamin nytamin deleted the fix/empty-reject branch January 29, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants