-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deno): allow test to succeed if there are no tests to run #305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this configurable. I'm okay with making it default to be on, like we do with @nx/jest, but people should be able to opt out if they so wish.
@barbados-clemens I've updated the PR according to your feedback. I have added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with changing this as a default as it's more or less the behavior expected IMO.
You did set the default to be true, so go a head and remove setting in the project configuration and leave it true.
If you're worried about breaking people then you can add a migration to update that property for everyone to be 'false' so it doesn't change, but IMO it's not a big deal.
packages/deno/src/generators/application/__snapshots__/application.spec.ts.snap
Outdated
Show resolved
Hide resolved
packages/deno/src/generators/application/__snapshots__/application.spec.ts.snap
Outdated
Show resolved
Hide resolved
packages/deno/src/generators/application/__snapshots__/application.spec.ts.snap
Outdated
Show resolved
Hide resolved
packages/deno/src/generators/application/__snapshots__/application.spec.ts.snap
Outdated
Show resolved
Hide resolved
packages/deno/src/generators/serverless/__snapshots__/serverless.spec.ts.snap
Outdated
Show resolved
Hide resolved
packages/deno/src/generators/serverless/__snapshots__/serverless.spec.ts.snap
Outdated
Show resolved
Hide resolved
packages/deno/src/generators/serverless/__snapshots__/serverless.spec.ts.snap
Outdated
Show resolved
Hide resolved
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 36dc4af. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
@barbados-clemens thanks for the feedback! Looks like I misunderstood how the default field in the schema functioned. I've made the changes as recommended. |
No description provided.