Implementation of configurable environment[stg, prod] #58
Conversation
pritam-bs
commented
Oct 30, 2023
•
pritam-bs
commented
- Flutter SDK version up
- update dependencies
- make stg, prod env configurable
- refactor nstack builder
- update dependencies - make stg, prod env configurable
lib/src/nstack_builder.dart
Outdated
| const _config = NStackConfig(projectId: '$projectId', apiKey: '$apiKey',); | ||
| const _config = NStackConfig(projectId: '$projectId', apiKey: '$apiKey', env: '$env'); |
There was a problem hiding this comment.
We might need to discuss this more, with this implementation you would need to rebuild the code if you want to switch environments, but what if someone wants to switch programmatically or using an env variable like dart-defines.
There was a problem hiding this comment.
The stg environment is only intended for NStack developers not for the end users.
There was a problem hiding this comment.
@pritam-bs can we document this in the code then? I know it's mentioned in the NStack docs, we can leave a link to it for example
There was a problem hiding this comment.
I will try to generate doc using the template system in future PRs.
- DartFormatter - Other changes
lib/src/nstack_template.txt
Outdated
| if (!_initializedNStack) { | ||
| _nstack | ||
| .appOpen(Localizations.localeOf(context), | ||
| platformOverride: widget.platformOverride) | ||
| .whenComplete(() => widget.onComplete?.call()); | ||
| _initializedNStack = true; |
There was a problem hiding this comment.
@pritam-bs yeah this is because in Localizations.localeOf we're trying to depend on an inherited widget before the widget is add such subscriptions. We should add WidgetBinding.instance.addPostFrameCallback or get the localization in didChangeDependencies (be careful though as didChangeDependencies is executed quite often when a top level inherited widget changes (more here). Let's do either of these options
There was a problem hiding this comment.
@pritam-bs I like how more compact and readable the code is now👍
Could you please install this linter package monstarlab_lints to ensure we maintain the needed code style?
- flutter sdk version up - build_runner version up - handle empty language response - other changes
