Implement VersionControl feature
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Provided NStackVersionControlWidget for the user to show version control dialog
There was a problem hiding this comment.
I'm not sure about forcing the devs to use native views, I still think they should be customisable.
@BucekJiri @nivisi what do you guys think?
…can customize the dialog. - Refactor snake case to camel case.
nivisi
suggested changes
Feb 12, 2024
There was a problem hiding this comment.
General suggestion: we have to think about the interface that we expose to the end users. What widgets and data classes will be visible. We must reduce the amount unclarity / inconvenience we'll provide with our package.
This can be done separately, in a PR that would solely focus on this.
- Restrict the use of the default dialog - Refactor variable name to follow the flutter convention
hassan-saleh-ml
requested changes
Feb 15, 2024
hassan-saleh-ml
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided
NStackVersionControlWidgetfor the devs to show version control dialogThe devs can pass the
onVersionUpdateNotificationfunction to get theUpdateobject and handle the update dialog themself.Or, to display a default adaptive dialog, they can set the
onVersionUpdateNotificationfunction tonulland configure the localization strings from the NStack console.