Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NStack SDK architectural changes #63

Merged
merged 4 commits into from
Apr 23, 2024
Merged

NStack SDK architectural changes #63

merged 4 commits into from
Apr 23, 2024

Conversation

pritam-bs
Copy link

@pritam-bs pritam-bs commented Apr 2, 2024 •
edited
Loading

  • Separate features like message and version control from NStackWidget
  • The newly introduced NStackFeatureHandlerWidget will be used for other NStack features
  • Only localization is the default for NStackWidget
  • Simplified the code generation part
  • Default localizations for the adaptive dialogue are configurable from the console.
  • Rearrange the folder structure
  • Change in example to facilitate the newly exposed APIs for NStackFeatureHandlerWidget
  • Expose async API to get message and version update info
  • Doc update
  • Refactor

@pritam-bs
NStack SDK architectural changes
ed183bd 
- Separate features like message and version control from NStackWidget
- The newly introduced NStackFeatureHandlerWidget will be used for other NStack features
- Only localization is the default for NStackWidget
- Simplified the code generation part
- Default localizations for the adaptive dialogue are configurable from the console.
- Rearrange the folder structure
@pritam-bs pritam-bs marked this pull request as draft April 8, 2024 06:53
@pritam-bs pritam-bs changed the title NStack SDK architectural changes [WIP] NStack SDK architectural changes Apr 8, 2024
@pritam-bs pritam-bs marked this pull request as ready for review April 12, 2024 08:06
@pritam-bs pritam-bs changed the title [WIP] NStack SDK architectural changes NStack SDK architectural changes Apr 12, 2024
@pritam-bs pritam-bs requested a review from nivisi April 12, 2024 21:06
nivisi
nivisi reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@nivisi nivisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My complains are rather minor. The rest LGTM!

lib/src/sdk/widgets/nstack_version_control_widget.dart Outdated Show resolved Hide resolved
lib/src/sdk/widgets/nstack_version_control_widget.dart Outdated Show resolved Hide resolved
lib/src/sdk/widgets/nstack_message_widget.dart Outdated Show resolved Hide resolved
lib/src/sdk/widgets/nstack_message_widget.dart Outdated Show resolved Hide resolved
lib/src/sdk/widgets/nstack_feature_handler_widget.dart Outdated Show resolved Hide resolved
lib/src/sdk/widgets/nstack_feature_handler_widget.dart Show resolved Hide resolved
lib/src/sdk/nstack_sdk.dart Outdated Show resolved Hide resolved
example/lib/screens/message_example_screen.dart Show resolved Hide resolved
@pritam-bs
- Moved getMessage API from NStack to NStackMessages
7070639 
- Moved getVersionInfo API from NStack to NStackVersionControl
- Other clean-ups
@pritam-bs pritam-bs requested a review from nivisi April 19, 2024 08:15
nivisi
nivisi approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@nivisi nivisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pritam-bs pritam-bs merged commit 31ddbe1 into develop Apr 23, 2024
1 check passed
@pritam-bs pritam-bs deleted the feat/architectural_changes branch April 23, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivisi nivisi nivisi approved these changes

@hassan-saleh-ml hassan-saleh-ml Awaiting requested review from hassan-saleh-ml

@BucekJiri BucekJiri Awaiting requested review from BucekJiri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pritam-bs @nivisi