Relax precommit config to not autofix prs #750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 17 17
Lines 1622 1622
=======================================
Hits 1484 1484
Misses 138 138 |
well if you install pre-commit with your local git hooks all is already fixed within each your commit :) or write black/flake8 compliant code ;) THB I ano t a fun of asking contributors to fix linting or need to checkout their PR and doing it for them if it could be done automatically for them... |
|
@Borda Since you have gone ahead and updated some of the linting CI, I'm fine with closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we look to modernize the repo's packaging, it would be helpful for the autofix feature of pre-commit to be turned off. I like the bot providing feedback. I'm not as fond of the PR being changed.