update Black with line 120 #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 17 17
Lines 1622 1622
=======================================
Hits 1484 1484
Misses 138 138 |
Borda
commented
Nov 21, 2023
|
@Borda If we use Ruff, I believe that we can remove black. |
tbh, never tried but still, I may tend to keep it... of have the same setting? :) |
|
Let's do this @Borda. I'll go ahead and merge this since I am a fan of 120. FYI on the differences between Ruff and Black for formatting. They are fairly subtle at the moment. https://docs.astral.sh/ruff/formatter/#the-ruff-formatter |
willingc
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
seems that the black config was a dummy one with lots of not-relevant settings to this project
Moreover changing the line length to 120 as it is already with flake8 and it common standard now