CI (Windows)

chore: prepare 1.0 release (#13) #62

Triggered via push February 28, 2024 14:42

leon3s

pushed 7034dcc

master

Status Success

Total duration 10m 33s

Artifacts –

windows.yml

on: push

Matrix: build_and_test

Annotations

43 warnings

needless `fn main` in doctest: ntex-files/src/lib.rs#L218

warning: needless `fn main` in doctest --> ntex-files/src/lib.rs:218:5 | 218 | /// use ntex::web::App; | _____^ 219 | | /// use ntex_files as fs; 220 | | /// 221 | | /// fn main() { 222 | | /// let app = App::new() 223 | | /// .service(fs::Files::new("/static", ".")); 224 | | /// } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main = note: `#[warn(clippy::needless_doctest_main)]` on by default

this returns a `Result<_, ()>`: ntex-files/src/range.rs#L16

warning: this returns a `Result<_, ()>` --> ntex-files/src/range.rs:16:5 | 16 | pub fn parse(header: &str, size: u64) -> Result<Vec<HttpRange>, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err = note: `#[warn(clippy::result_unit_err)]` on by default

this call to `as_ref` does nothing: ntex-files/src/file_header/parsing.rs#L38

warning: this call to `as_ref` does nothing --> ntex-files/src/file_header/parsing.rs:38:32 | 38 | let s = str::from_utf8(s.as_ref())?; | ^^^^^^^^^^ help: try: `s` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref = note: `#[warn(clippy::useless_asref)]` on by default

this `impl` can be derived: ntex-files/src/file_header/method.rs#L144

warning: this `impl` can be derived --> ntex-files/src/file_header/method.rs:144:1 | 144 | / impl Default for Method { 145 | | fn default() -> Method { 146 | | Method::Get 147 | | } 148 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it... | 17 + #[derive(Default)] 18 | pub enum Method { | help: ...and mark the default variant | 21 ~ #[default] 22 ~ Get, |

redundant slicing of the whole range: ntex-files/src/file_header/entity.rs#L125

warning: redundant slicing of the whole range --> ntex-files/src/file_header/entity.rs:125:21 | 125 | let slice = &s[..]; | ^^^^^^ help: use the original value instead: `s` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing = note: `#[warn(clippy::redundant_slicing)]` on by default

all variants have the same prefix: `Bad`: ntex-files/src/error.rs#L42

warning: all variants have the same prefix: `Bad` --> ntex-files/src/error.rs:42:1 | 42 | / pub enum UriSegmentError { 43 | | /// The segment started with the wrapped invalid character. 44 | | #[display(fmt = "The segment started with the wrapped invalid character")] 45 | | BadStart(char), ... | 51 | | BadEnd(char), 52 | | } | |_^ | = help: remove the prefixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names = note: `#[warn(clippy::enum_variant_names)]` on by default

method `clone_box` is never used: ntex-files/src/file_header/mod.rs#L66

warning: method `clone_box` is never used --> ntex-files/src/file_header/mod.rs:66:12 | 65 | pub trait HeaderClone { | ----------- method in this trait 66 | fn clone_box(&self) -> Box<dyn Header + Send + Sync>; | ^^^^^^^^^

method `len` is never used: ntex-files/src/file_header/raw.rs#L12

warning: method `len` is never used --> ntex-files/src/file_header/raw.rs:12:8 | 7 | pub trait RawLike<'a> { | ------- method in this trait ... 12 | fn len(&'a self) -> usize; | ^^^

trait `AssertSendSync` is never used: ntex-files/src/file_header/error.rs#L92

warning: trait `AssertSendSync` is never used --> ntex-files/src/file_header/error.rs:92:7 | 92 | trait AssertSendSync: Send + Sync + 'static {} | ^^^^^^^^^^^^^^

associated items `weak`, `tag`, `set_tag`, `strong_ne`, and `weak_ne` are never used: ntex-files/src/file_header/entity.rs#L63

warning: associated items `weak`, `tag`, `set_tag`, `strong_ne`, and `weak_ne` are never used --> ntex-files/src/file_header/entity.rs:63:12 | 51 | impl EntityTag { | -------------- associated items in this implementation ... 63 | pub fn weak(tag: String) -> EntityTag { | ^^^^ ... 75 | pub fn tag(&self) -> &str { | ^^^ ... 82 | pub fn set_tag(&mut self, tag: String) { | ^^^^^^^ ... 101 | pub fn strong_ne(&self, other: &EntityTag) -> bool { | ^^^^^^^^^ ... 106 | pub fn weak_ne(&self, other: &EntityTag) -> bool { | ^^^^^^^

trait `StandardHeader` is never used: ntex-files/src/file_header/mod.rs#L184

warning: trait `StandardHeader` is never used --> ntex-files/src/file_header/mod.rs:184:11 | 184 | pub trait StandardHeader: Header + Sized { | ^^^^^^^^^^^^^^

method `danger_fmt_line_without_newline_replacer` is never used: ntex-files/src/file_header/mod.rs#L126

warning: method `danger_fmt_line_without_newline_replacer` is never used --> ntex-files/src/file_header/mod.rs:126:8 | 88 | impl<'a, 'b> Formatter<'a, 'b> { | ------------------------------ method in this implementation ... 126 | fn danger_fmt_line_without_newline_replacer<T: std::fmt::Display>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

associated items `header_name` and `fmt_header` are never used: ntex-files/src/file_header/mod.rs#L29

warning: associated items `header_name` and `fmt_header` are never used --> ntex-files/src/file_header/mod.rs:29:8 | 25 | pub trait Header: 'static + HeaderClone + Send + Sync { | ------ associated items in this trait ... 29 | fn header_name() -> &'static str | ^^^^^^^^^^^ ... 58 | fn fmt_header(&self, f: &mut Formatter) -> std::fmt::Result; | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

methods called `from_*` usually take no `self`: ntex-identity/src/lib.rs#L184

warning: methods called `from_*` usually take no `self` --> ntex-identity/src/lib.rs:184:21 | 184 | fn from_request(&self, request: &mut WebRequest<Err>) -> Self::Future; | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `#[warn(clippy::wrong_self_convention)]` on by default

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: ntex-cors/src/lib.rs#L198

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> ntex-cors/src/lib.rs:198:17 | 198 | / vec![ 199 | | Method::GET, 200 | | Method::HEAD, 201 | | Method::POST, ... | 206 | | ] 207 | | .into_iter(), | |____________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/ef324565d071c6d7e2477a195648549e33d6a465/library/core/src/iter/traits/collect.rs:150:21 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default help: consider removing the `.into_iter()` | 198 ~ vec![ 199 + Method::GET, 200 + Method::HEAD, 201 + Method::POST, 202 + Method::OPTIONS, 203 + Method::PUT, 204 + Method::PATCH, 205 + Method::DELETE, 206 ~ ], |

method `default` can be confused for the standard trait method `std::default::Default::default`: ntex-cors/src/lib.rs#L193

warning: method `default` can be confused for the standard trait method `std::default::Default::default` --> ntex-cors/src/lib.rs:193:5 | 193 | / pub fn default<Err>() -> CorsFactory<Err> { 194 | | let inner = Inner { 195 | | origins: AllOrSome::default(), 196 | | origins_str: None, ... | 217 | | CorsFactory { inner: Rc::new(inner), _t: PhantomData } 218 | | } | |_____^ | = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait = note: `#[warn(clippy::should_implement_trait)]` on by default

the item `AsRef` is imported redundantly: ntex-files/src/file_header/method.rs#L2

warning: the item `AsRef` is imported redundantly --> ntex-files/src/file_header/method.rs:2:20 | 2 | use std::convert::{AsRef, TryFrom}; | ^^^^^ --> /rustc/ef324565d071c6d7e2477a195648549e33d6a465/library/std/src/prelude/mod.rs:115:13 | = note: the item `AsRef` is already defined here | = note: `#[warn(unused_imports)]` on by default

nightly - x86_64-pc-windows-msvc

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/cache@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

nightly - x86_64-pc-windows-msvc

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

nightly - x86_64-pc-windows-msvc

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

nightly - x86_64-pc-windows-msvc