Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor client api #17

Merged
merged 8 commits into from
Oct 2, 2023
Merged

Refactor client api #17

merged 8 commits into from
Oct 2, 2023

Conversation

fafhrd91
Copy link
Member

@fafhrd91 fafhrd91 commented Oct 2, 2023

  • Refactor client api
  • Add client connection pool

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 152 lines in your changes are missing coverage. Please review.

Comparison is base (9ce6d8c) 83.09% compared to head (f8c1a5c) 82.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   83.09%   82.46%   -0.64%     
==========================================
  Files          39       41       +2     
  Lines        6538     6905     +367     
==========================================
+ Hits         5433     5694     +261     
- Misses       1105     1211     +106     
Files Coverage Δ
src/client/client.rs 68.18% <100.00%> (+15.02%) ⬆️
src/stream.rs 72.98% <100.00%> (+0.31%) ⬆️
src/client/mod.rs 0.00% <0.00%> (ø)
src/client/connector.rs 0.00% <0.00%> (ø)
src/client/stream.rs 70.31% <70.31%> (ø)
src/client/pool.rs 60.07% <60.07%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fafhrd91 fafhrd91 merged commit 435f471 into main Oct 2, 2023
5 of 7 checks passed
@fafhrd91 fafhrd91 deleted the client-pool branch October 2, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant