Derive Hash for the QoS enum (#175) #928
Annotations
5 errors and 12 warnings
using `map_err` over `inspect_err`:
src/v5/shared.rs#L212
error: using `map_err` over `inspect_err`
--> src/v5/shared.rs:212:33
|
212 | self.pkt_ack_inner(ack).map_err(|e| {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
help: try
|
212 ~ self.pkt_ack_inner(ack).inspect_err(|e| {
213 | self.close(codec::Disconnect {
214 | reason_code: codec::DisconnectReasonCode::ImplementationSpecificError,
215 | ..Default::default()
216 ~ });
|
|
using `map_err` over `inspect_err`:
src/v3/shared.rs#L195
error: using `map_err` over `inspect_err`
--> src/v3/shared.rs:195:33
|
195 | self.pkt_ack_inner(ack).map_err(|e| {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[deny(clippy::manual_inspect)]` implied by `#[deny(warnings)]`
help: try
|
195 ~ self.pkt_ack_inner(ack).inspect_err(|e| {
196 ~ self.close();
|
|
this manual char comparison can be written more succinctly:
src/topic.rs#L211
error: this manual char comparison can be written more succinctly
--> src/topic.rs:211:39
|
211 | if level.contains(|c| c == '+' || c == '#') {
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['+', '#']`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
|
this manual char comparison can be written more succinctly:
src/topic.rs#L52
error: this manual char comparison can be written more succinctly
--> src/topic.rs:52:29
|
52 | !s.contains(|c| c == '+' || c == '#')
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['+', '#']`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
note: the lint level is defined here
--> src/lib.rs:1:27
|
1 | #![deny(rust_2018_idioms, warnings, unreachable_pub)]
| ^^^^^^^^
= note: `#[deny(clippy::manual_pattern_char_comparison)]` implied by `#[deny(warnings)]`
|
stable - x86_64-pc-windows-msvc
The process 'C:\Users\runneradmin\.cargo\bin\cargo.exe' failed with exit code 101
|
stable - x86_64-pc-windows-msvc
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
stable - x86_64-pc-windows-msvc
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/cache@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
stable - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
stable - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
stable - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
stable - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
nightly - x86_64-pc-windows-msvc
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
nightly - x86_64-pc-windows-msvc
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/cache@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
nightly - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
nightly - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
nightly - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
nightly - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|