Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Hash for the QoS enum #175

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

svanharmelen
Copy link
Contributor

We would like to be able to use the QoS as part of a HashMap key (e.g. HashMap<((String, QoS), ...>), but for that QoS needs to implement the Hash trait.

@fafhrd91
Copy link
Member

thank!

@fafhrd91 fafhrd91 merged commit 108a390 into ntex-rs:master Aug 23, 2024
7 of 9 checks passed
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.04%. Comparing base (e8e496d) to head (62b0fca).
Report is 1 commits behind head on master.

Files Patch % Lines
src/types.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   71.09%   71.04%   -0.06%     
==========================================
  Files          52       52              
  Lines        8709     8717       +8     
==========================================
+ Hits         6192     6193       +1     
- Misses       2517     2524       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svanharmelen
Copy link
Contributor Author

Thanks for the super quick merge and release @fafhrd91 ❤️

@svanharmelen svanharmelen deleted the feat/qos-hash branch August 23, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants