Fixes halt on new column addition being too strict (#3161)

nucleuscloud · Jan 18, 2025 · 4d1e222 · 4d1e222
1 parent 8b6ea3e
commit 4d1e222
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/internal/benthos/benthos-builder/builders/benthos-builder_test.go b/internal/benthos/benthos-builder/builders/benthos-builder_test.go
@@ -242,8 +242,7 @@ func TestShouldHaltOnSchemaAddition(t *testing.T) {
 			{Schema: "public", Table: "users", Column: "created_by"},
 		},
 	)
-	require.True(t, ok, "job mappings are missing database schema mappings")
-	require.ElementsMatch(t, []string{"neosync_api.accounts.id", "neosync_api.accounts.name"}, newCols)
+	require.False(t, ok, "valid subset of job mappings")
 
 	newCols, ok = shouldHaltOnSchemaAddition(
 		map[string]map[string]*sqlmanager_shared.DatabaseSchemaRow{

diff --git a/internal/benthos/benthos-builder/builders/sql-util.go b/internal/benthos/benthos-builder/builders/sql-util.go
@@ -96,7 +96,11 @@ func shouldHaltOnSchemaAddition(
 	tableColMappings := getUniqueColMappingsMap(mappings)
 	newColumns := []string{}
 	for table, cols := range groupedSchemas {
-		mappingCols := tableColMappings[table]
+		mappingCols, exists := tableColMappings[table]
+		if !exists {
+			// table not mapped in job mappings, skip
+			continue
+		}
 		for col := range cols {
 			if _, exists := mappingCols[col]; !exists {
 				newColumns = append(newColumns, fmt.Sprintf("%s.%s", table, col))