Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add job mapping validation #2061

Merged
merged 14 commits into from
May 30, 2024
Merged

add job mapping validation #2061

merged 14 commits into from
May 30, 2024

Conversation

alishakawaguchi
Copy link
Contributor

No description provided.

@alishakawaguchi alishakawaguchi self-assigned this May 30, 2024
Copy link

linear bot commented May 30, 2024

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 6:07pm

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 10.69246% with 877 lines in your changes are missing coverage. Please review.

Project coverage is 17.96%. Comparing base (9c11fe5) to head (da14413).
Report is 11 commits behind head on main.

Current head da14413 differs from pull request most recent head bb79729

Please upload reports for the commit bb79729 to get more accurate results.

Files Patch % Lines
...rotos/mgmt/v1alpha1/connection_data.pb.validate.go 0.00% 225 Missing ⚠️
...end/gen/go/protos/mgmt/v1alpha1/job.pb.validate.go 0.00% 212 Missing ⚠️
backend/gen/go/protos/mgmt/v1alpha1/job.pb.go 0.63% 156 Missing ⚠️
.../gen/go/protos/mgmt/v1alpha1/connection_data.pb.go 0.83% 119 Missing ⚠️
...1alpha1/connection-data-service/connection-data.go 0.00% 55 Missing ⚠️
backend/services/mgmt/v1alpha1/job-service/jobs.go 70.00% 29 Missing and 13 partials ⚠️
backend/internal/utils/utils.go 0.00% 28 Missing ⚠️
...ha1/mgmtv1alpha1connect/connection_data.connect.go 0.00% 18 Missing ⚠️
...s/mgmt/v1alpha1/mgmtv1alpha1connect/job.connect.go 0.00% 18 Missing ⚠️
backend/internal/cmds/mgmt/serve/connect/cmd.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2061      +/-   ##
==========================================
+ Coverage   17.90%   17.96%   +0.05%     
==========================================
  Files         215      215              
  Lines       46684    47861    +1177     
==========================================
+ Hits         8361     8599     +238     
- Misses      37285    38200     +915     
- Partials     1038     1062      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alishakawaguchi alishakawaguchi merged commit 786f0ca into main May 30, 2024
12 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/neos-1110-validate branch May 30, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant