exposes simple version in support header #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
alishakawaguchi
approved these changes
Sep 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
==========================================
+ Coverage 29.59% 36.82% +7.22%
==========================================
Files 285 285
Lines 26673 26673
==========================================
+ Hits 7893 9821 +1928
+ Misses 17753 15554 -2199
- Partials 1027 1298 +271 ☔ View full report in Codecov by Sentry. |
evisdrenova
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version seen in the screenshot is the untagged, default development version.
In production users will see:
v0.x.xWe can make this better over time but I wanted to at a minimum expose the neosync version somewhere as this would have helped people in the past during debug sessions on discord.
I also went ahead and updated the proto to mark this method as having no side effects so it can be used in GET requests.
Similar to how Temporal exposes this information on their site header in their cloud version
