Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1562: convert record limit to time based in account status #2842

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

nickzelei
Copy link
Member

No description provided.

Copy link

linear bot commented Oct 23, 2024

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 8:23pm

@nickzelei nickzelei added the enhancement New feature or request label Oct 23, 2024
Copy link

github-actions bot commented Oct 23, 2024

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 23, 2024, 8:23 PM

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 84.88372% with 13 lines in your changes missing coverage. Please review.

Project coverage is 38.81%. Comparing base (82f237a) to head (7f4a619).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ices/mgmt/v1alpha1/user-account-service/billing.go 85.88% 9 Missing and 3 partials ⚠️
backend/internal/cmds/mgmt/serve/connect/cmd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2842      +/-   ##
==========================================
+ Coverage   37.39%   38.81%   +1.41%     
==========================================
  Files         297      297              
  Lines       34741    34697      -44     
==========================================
+ Hits        12992    13468     +476     
+ Misses      20207    19593     -614     
- Partials     1542     1636      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei force-pushed the nick/neos-1562-convert-record-limit-to-time-based branch from 223a78d to 67257b2 Compare October 23, 2024 20:04
@nickzelei nickzelei merged commit 8155544 into main Oct 23, 2024
21 checks passed
@nickzelei nickzelei deleted the nick/neos-1562-convert-record-limit-to-time-based branch October 23, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants