Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1559: add ability to limit db connections via cli #2867

Merged

Conversation

nickzelei
Copy link
Member

No description provided.

@nickzelei nickzelei added the enhancement New feature or request label Oct 25, 2024
Copy link

linear bot commented Oct 25, 2024

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 6:03pm

Copy link

github-actions bot commented Oct 25, 2024

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 25, 2024, 6:03 PM

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 12.35955% with 78 lines in your changes missing coverage. Please review.

Project coverage is 39.00%. Comparing base (27c2f1b) to head (c3e1935).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cli/internal/cmds/neosync/sync/config.go 0.00% 31 Missing ⚠️
cli/internal/cmds/neosync/sync/sync.go 0.00% 26 Missing ⚠️
backend/pkg/sqlconnect/sql-connector.go 42.30% 12 Missing and 3 partials ⚠️
backend/sql/postgresql/models/models.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2867      +/-   ##
==========================================
- Coverage   39.08%   39.00%   -0.08%     
==========================================
  Files         303      303              
  Lines       35334    35407      +73     
==========================================
+ Hits        13809    13810       +1     
- Misses      19859    19926      +67     
- Partials     1666     1671       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alishakawaguchi alishakawaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nickzelei nickzelei merged commit 57c31f4 into main Oct 25, 2024
19 of 21 checks passed
@nickzelei nickzelei deleted the nick/neos-1559-add-ability-to-limit-db-connections-via-cli branch October 25, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants