Deprecates Source in JobMappingTransformer config #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
nickzelei
commented
Oct 25, 2024
|
|
||
| interface Props { | ||
| row: Row<{ schema: string; table: string; column: string }>; |
There was a problem hiding this comment.
TS was continually unhappy about this even though it builds. This update just makes it less type dependent on the Row type and pushes it to the caller.
nickzelei
commented
Oct 25, 2024
| return ( | ||
| <div className="flex flex-row gap-2 items-center"> | ||
| <SchemaRowAlert | ||
| row={row} | ||
| rowKey={columnKey} |
There was a problem hiding this comment.
much cleaner, doesn't expose the Row anymore to this component and fixes the weird build error that kept showing up here.
nickzelei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.