Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Multivariate threshold using Mahalanobis distance #234
feat: Multivariate threshold using Mahalanobis distance #234
Changes from all commits
98afcae
2196fc6
777d451
72bcf67
359f5d2
9dfe615
22a8ec9
2da4ea0
929d93b
0ebe64e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x_distance
is a matrix of shape (n_obs, n_features)._cov_inv
is (n_features, n_features),mahal_grid
is (n_obs, n_obs). Therefore, it works on a matrix, not a number.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
x
is expected to be array of vectors, not just one vector.On a related note, is there a means to include dimension in the param type? Presently, type like
npt.NDArray[float]
doesn't carry dimension info.