Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test cases mlflow registry #415

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix: test cases mlflow registry #415

merged 3 commits into from
Sep 19, 2024

Conversation

yleilawang
Copy link
Collaborator

@yleilawang yleilawang commented Sep 18, 2024

There existed errors in test logs while test cases still passed. One example is the ConnectionError due to not mocking mlflow function calls properly.

Fixed through modifying a few syntax for patch mock calls. The test cases should pass with no logging errors now.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (f6ce546) to head (1d5cbbc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   92.18%   92.16%   -0.02%     
==========================================
  Files          97       97              
  Lines        4775     4776       +1     
  Branches      429      429              
==========================================
  Hits         4402     4402              
  Misses        276      276              
- Partials       97       98       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s0nicboOm s0nicboOm marked this pull request as ready for review September 18, 2024 19:25
Copy link
Contributor

@s0nicboOm s0nicboOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ab93 ab93 merged commit b18b2d2 into main Sep 19, 2024
13 checks passed
@ab93 ab93 deleted the test_case branch September 19, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants