feat(src): add content credential pin support #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for a content credential pin to display the C2PA verification result on the C2PA verify page.
shc261392
reviewed
Jan 23, 2025
src/modal/modal.ts
Outdated
| @@ -84,6 +85,8 @@ export class CaptureEyeModal extends LitElement { | |||
|
|
|||
| @query('.modal') modalElement!: HTMLDivElement; | |||
|
|
|||
| private _c2paNid = ''; | |||
There was a problem hiding this comment.
Since the variable is supposed to be an url, not an nid, the naming should reflect that
src/modal/modal.ts
Outdated
| @@ -547,6 +600,45 @@ export class CaptureEyeModal extends LitElement { | |||
| } | |||
| } | |||
|
|
|||
| private handleInspectContentCredentials() { | |||
| if (this._c2paNid) { | |||
| window.open(this._c2paNid); | |||
There was a problem hiding this comment.
Suggested change
| window.open(this._c2paNid); | |
| window.open(this._c2paNid, '_blank', 'noopener,noreferrer'); |
Consider having these arguments for more consistent behavior and security for older browsers
shc261392
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added