Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Fix Directory::Iterator::~Iterator() implicitly being no-except #1449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/nupic/os/Directory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ void Iterator::init(const std::string &path) {
<< ". OS num: " << APR_TO_OS_ERROR(res);
}

Iterator::~Iterator() {
Iterator::~Iterator() noexcept(false) {
apr_status_t res = ::apr_dir_close(handle_);
::apr_pool_destroy(pool_);
NTA_CHECK(res == 0) << "Couldn't close directory."
Expand Down
2 changes: 1 addition & 1 deletion src/nupic/os/Directory.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class Iterator {
public:
Iterator(const Path &path);
Iterator(const std::string &path);
~Iterator();
~Iterator() noexcept(false);

// Resets directory to start. Subsequent call to next()
// will retrieve the first entry
Expand Down