Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️(frontend) Version new types #277

Merged
merged 3 commits into from
Sep 30, 2024
Merged

♻️(frontend) Version new types #277

merged 3 commits into from
Sep 30, 2024

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Sep 23, 2024

Purpose

We fixed the 404 error, so we reactivated the version feature in the doc header.
We refactored the Panel to have the feature Table of content and Versions in the same panel.

Proposal

  • 👔(frontend) adapt versions api with new types
  • ♻️(frontend) minor components refacto
  • ♻️(frontend) add versions in the panel editor
  • Tests

Demo

scrnli_9_30_2024_4-14-09.PM.webm

@AntoLC AntoLC self-assigned this Sep 23, 2024
@AntoLC AntoLC force-pushed the refacto/version-new-types branch 2 times, most recently from 012e119 to ba662ac Compare September 30, 2024 14:03
@AntoLC AntoLC added the feature label Sep 30, 2024
We updated the backend recently, the types of the
versions list has changed.
This commit adapts the frontend to the new types.
Improve some props in different components.
We add the features version to the panel editor.
We had to refactor the panel to be able to
have the version with the table of content in
the same panel.
@AntoLC AntoLC marked this pull request as ready for review September 30, 2024 15:08
@AntoLC AntoLC merged commit ac74db2 into main Sep 30, 2024
16 of 17 checks passed
@AntoLC AntoLC deleted the refacto/version-new-types branch September 30, 2024 15:26
@AntoLC AntoLC mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant