Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Fine tuning before release 1.5.0 #313

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Oct 9, 2024

Purpose

Small fixes and improvement before the release to 1.5.0.

Proposal

  • ✨(frontend) add back the footer and cgu pages
  • ♻️(frontend) remove share button when not logged in

@AntoLC AntoLC added the frontend label Oct 9, 2024
@AntoLC AntoLC self-assigned this Oct 9, 2024
@AntoLC AntoLC changed the title ✨(frontend) add back the footer and cgu pages ♻️Fine tuning before release 1.5.0 Oct 9, 2024
We need to add back the footer and cgu pages,
but we will not display the footer on the doc
editor pages.
We remove the share button if the user is not
logged in. Most of the elements in the share modal
nececessitate the user to be logged in.
@AntoLC AntoLC marked this pull request as ready for review October 9, 2024 13:55
@AntoLC AntoLC mentioned this pull request Oct 9, 2024
@AntoLC AntoLC merged commit 86085f8 into main Oct 9, 2024
16 of 17 checks passed
@AntoLC AntoLC deleted the refacto/fine-tuning-1.5.0 branch October 9, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant