♻️ Add username in email #314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virgile-dev
reviewed
Oct 9, 2024
| @@ -31,7 +31,7 @@ | |||
| <!-- Main Message --> | |||
| <mj-text> | |||
| {% blocktrans %} | |||
| {{username}} invited you as an {{role}} on the following document : | |||
| {{username}} {{email}} invited you as an {{role}} on the following document : | |||
There was a problem hiding this comment.
{{username}} ({{email}}) invited you with the role "{{role}}" on the following document :
There was a problem hiding this comment.
why do we want to add the email here?
sampaccoud
reviewed
Oct 9, 2024
| access.document.email_invitation( | ||
| language, access.user.email, access.role, self.request.user.email | ||
| language, access.user.email, access.role, username_sender, email_sender |
There was a problem hiding this comment.
Semantically, shouldn't it be:
Suggested change
| language, access.user.email, access.role, username_sender, email_sender | |
| language, access.user.email, access.role, sender_name, sender_email |
The term "username" is usually used with another meaning.
| @@ -520,7 +520,7 @@ def get_abilities(self, user): | |||
| "versions_retrieve": can_get_versions, | |||
| } | |||
|
|
|||
| def email_invitation(self, language, email, role, username_sender): | |||
| def email_invitation(self, language, email, role, username_sender, email_sender): | |||
There was a problem hiding this comment.
Suggested change
| def email_invitation(self, language, email, role, username_sender, email_sender): | |
| def email_invitation(self, language, email, role, username_sender, sender_email): |
| @@ -31,7 +31,7 @@ | |||
| <!-- Main Message --> | |||
| <mj-text> | |||
| {% blocktrans %} | |||
| {{username}} invited you as an {{role}} on the following document : | |||
| {{username}} {{email}} invited you as an {{role}} on the following document : | |||
There was a problem hiding this comment.
why do we want to add the email here?
Comment on lines
+789
to
+790
| username_sender = self.request.user.full_name | ||
| email_sender = self.request.user.email |
There was a problem hiding this comment.
Suggested change
| username_sender = self.request.user.full_name | |
| email_sender = self.request.user.email | |
| sender_name = self.request.user.full_name | |
| sender_email = self.request.user.email |
Comment on lines
+580
to
+581
| username_sender = self.request.user.full_name | ||
| email_sender = self.request.user.email |
There was a problem hiding this comment.
Suggested change
| username_sender = self.request.user.full_name | |
| email_sender = self.request.user.email | |
| sender_name = self.request.user.full_name | |
| sender_email = self.request.user.email |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
For the moment we are using the sender's email in the email, but we have sometimes the full name of the sender.
Proposal
Use the fullname instead of the email if it is available.