✨(frontend) Template builder #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/template-builder
branch
2 times, most recently
from
b5a6100
to
e28b915
Compare
We created the features templates. It will be used to create, edit and delete templates. It is a naive copy of pads.
We add the template builder editor to the template feature. It will be used to create and edit templates.
To save the template code editor content, we need to add a new column on the Template model. It is a JSONField that will store the code editor content. We could in the future make an implementation to save the code editor content in Minio.
On almost each change in the code editor, the template is saved automatically. It will restore as well the editor when we arrive on the template editor page.
partial_update action was missing for the permission. So when we were patching the template, it was not working. This commit adds the partial_update action to the abilities.
We want to be able to update the css and code of a template from the update endpoint. This commit adds the css and code fields to the TemplateSerializer.
We created a button to save the template's html and css. With the template saved we will be able to use it in the near future with our pads.
Add the effect prop on Box component. 2 effects are available: 'show' and 'hide'.
AntoLC
force-pushed
the
feature/template-builder
branch
2 times, most recently
from
5d03577
to
bb0ab50
Compare
In order to work with the pad, the body tag must be in the template. This commit adds a warning to the template editor when the body tag is not in the template.
AntoLC
force-pushed
the
feature/template-builder
branch
from
bb0ab50
to
3bc79fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The pads editors edit inside a template, but until now we couldn't easily create and edit this template.
We had to add it manually in the database, it was not suited for a real situation.
Proposal