Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️(backend) refactor post hackathon to a first working version #4

Merged
merged 1 commit into from
Feb 23, 2024
Merged

♻️(backend) refactor post hackathon to a first working version #4

merged 1 commit into from
Feb 23, 2024

Conversation

sampaccoud
Copy link
Contributor

Purpose

This project was copied from https://github.com/numerique-gouv/people and hacked to make a POC in a 2-day hackathon. We need to clean and refactor things in order to get a first version of the product we want.

Proposal

Make backend work as expected by our proof of concept:

  • remove unrelated code
  • refactor until tests pass

@sampaccoud sampaccoud self-assigned this Feb 16, 2024
@sampaccoud sampaccoud added the enhancement New feature or request label Feb 16, 2024
lebaudantoine
lebaudantoine approved these changes Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@lebaudantoine lebaudantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/backend/core/models.py Outdated Show resolved Hide resolved
src/backend/core/models.py Show resolved Hide resolved
src/backend/core/models.py Outdated Show resolved Hide resolved
src/backend/core/admin.py Show resolved Hide resolved
src/backend/core/api/permissions.py Outdated Show resolved Hide resolved
src/backend/core/tests/test_models_template_accesses.py Outdated Show resolved Hide resolved
src/backend/core/tests/test_models_templates.py Outdated Show resolved Hide resolved
src/backend/core/tests/test_models_templates.py Outdated Show resolved Hide resolved
src/backend/core/tests/test_api_template_accesses.py Show resolved Hide resolved
src/backend/core/tests/test_api_template_accesses.py Outdated Show resolved Hide resolved
@sampaccoud
Copy link
Contributor Author

@lebaudantoine maybe you should checkout the fixup commit before merge.

@sampaccoud sampaccoud force-pushed the refactor-template-vs-team branch 2 times, most recently from 212ccdf to 7edfffb Compare February 22, 2024 20:35
lebaudantoine
lebaudantoine reviewed Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@lebaudantoine lebaudantoine left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments in the admin:

  • Identity-related fields should be read-only?
  • Should we display the admin's email when the identity's email is not defined in as the username in the Django Admin? lmk if this comment is unclear
Capture d’écran 2024-02-23 à 13 52 05

@sampaccoud sampaccoud force-pushed the refactor-template-vs-team branch 2 times, most recently from 35909b2 to 5588389 Compare February 23, 2024 17:33
@sampaccoud
Copy link
Contributor Author

sampaccoud commented Feb 23, 2024 •
edited
Loading

@lebaudantoine all good points 🙏 I improved the whole user admin view to match what was done on https://github.com/numerique-gouv/people:

Screenshot from 2024-02-23 18-40-53

@sampaccoud
♻️(backend) refactor post hackathon to a first working version
c8f1b75 
This project was copied and hacked to make a POC in a 2-day hackathon.
We need to clean and refactor things in order to get a first version
of the product we want.
@sampaccoud sampaccoud merged commit 0f9327a into main Feb 23, 2024
7 of 10 checks passed
@AntoLC AntoLC deleted the refactor-template-vs-team branch August 7, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebaudantoine lebaudantoine lebaudantoine approved these changes

Assignees

@sampaccoud sampaccoud

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampaccoud @lebaudantoine