Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Display Grist status as in beta #65

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

fflorent
Copy link
Contributor

Purpose

grist.numerique.gouv.fr is officially in beta and should be displayed as is in the landing page.

Proposal

Add a status: "Beta" property.

@fflorent
Copy link
Contributor Author

Waiting for @vviers' validation before opening this PR.

@vviers
Copy link
Collaborator

vviers commented Feb 25, 2025

I'm don't think grist has an official beta status since we don't really know what "beta" means 🤔 is there a definition somewhere on the website ?

@fflorent
Copy link
Contributor Author

The logo on grist.numerique.gouv.fr mentions we're in beta:
DINUM Grist instance logo

It has brought confusion for some of our users.

@vviers
Copy link
Collaborator

vviers commented Feb 26, 2025

We circled back with Samuel and decided that this was not a mistake. We'll look into removing the beta tag from our instance.

@vviers vviers closed this Feb 26, 2025
@vviers
Copy link
Collaborator

vviers commented Mar 5, 2025

Actually, it looks like DINUM decided the beta logo need to come back ! reopening the PR

@vviers vviers reopened this Mar 5, 2025
@vviers vviers marked this pull request as ready for review March 5, 2025 11:18
@elvoisin elvoisin self-requested a review March 5, 2025 13:05
@vviers
Copy link
Collaborator

vviers commented Mar 5, 2025

@fflorent could you edit your commit to please the linter gods ?

grist.numerique.gouv.fr is officially in beta and
should be displayed as is in the landing page.
@fflorent
Copy link
Contributor Author

fflorent commented Mar 5, 2025

I hope I made the required changes to conform with the rules. I had to take a look at the code here:

pattern = r"^({:s})\(.*\)\s[a-z].*$".format("|".join(emojis))

And I had to understand that the subject has to have its first letter in lowercase.

To be honest, it has been painful for a little patch:

  1. The workflows are not run immediately (so the feedback loop is very slow), several hours after my last push it has not run yet, I don't understand when they will be;
  2. The rules are unclear, as stated above;
  3. There is no explanation how to setup tools to check the commits;

Here are my suggestions (I am OK for implementing them):

  1. Make explicit the rules to follow to add commits;
  2. Make the workflow run immediately, unless there exists reasons for not allowing that;
  3. Add a more accurate error message (explaining a first letter in lowercase is expected) or support for capitalized first letter;
  4. Add a contribution guide;
  5. Add to the PR template some guidance in comments on how to check the commits (npm run lint + gitlint);
  6. Add a npm command to run gitlint in a bash script;
  7. Add a contribution guide;
  8. If they exist, it would be very helpful to add tools to help creating commit messages (not all user environments allow adding emoji in a simple way);

What do you think?

@lebaudantoine
Copy link
Contributor

@fflorent, these rules already exist and are publicly documented: Suite Numérique Handbook. They were written down during the séminaire and later shared openly. Did you attend it?

Since you forked the project, the CI doesn’t run automatically without a maintainer’s review—that’s expected behavior on GitHub for security reasons. In such cases, you could have pinged one of us in the Tchap channel. I’m generally more responsive on Tchap than via GitHub notifications, especially there is no active maintainer of this Landing, it's a best effort.

That said, I understand that these commit rules can be a bit painful for a first contribution. Now that you're aware, you’re free to contribute to any La Suite project, let's see the positive side of things. If you’d like, feel free to start a discussion in the La Suite devroom, to challenge the gitmoji, you could raise your voice, and other developers might follow along ;)

Regarding your suggestions, please proceed with points 4/5/6/7/8. This landing page is primarily marketing material, updated occasionally when they revise the copywriting. Contributions are, of course, welcome, but the focus is more on structured digital commons like documentation or Grist.

@lebaudantoine lebaudantoine merged commit cf2519e into numerique-gouv:main Mar 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants