-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Display Grist status as in beta #65
Conversation
Waiting for @vviers' validation before opening this PR. |
I'm don't think grist has an official beta status since we don't really know what "beta" means 🤔 is there a definition somewhere on the website ? |
We circled back with Samuel and decided that this was not a mistake. We'll look into removing the beta tag from our instance. |
Actually, it looks like DINUM decided the beta logo need to come back ! reopening the PR |
@fflorent could you edit your commit to please the linter gods ? |
grist.numerique.gouv.fr is officially in beta and should be displayed as is in the landing page.
I hope I made the required changes to conform with the rules. I had to take a look at the code here:
And I had to understand that the subject has to have its first letter in lowercase. To be honest, it has been painful for a little patch:
Here are my suggestions (I am OK for implementing them):
What do you think? |
@fflorent, these rules already exist and are publicly documented: Suite Numérique Handbook. They were written down during the séminaire and later shared openly. Did you attend it? Since you forked the project, the CI doesn’t run automatically without a maintainer’s review—that’s expected behavior on GitHub for security reasons. In such cases, you could have pinged one of us in the Tchap channel. I’m generally more responsive on Tchap than via GitHub notifications, especially there is no active maintainer of this Landing, it's a best effort. That said, I understand that these commit rules can be a bit painful for a first contribution. Now that you're aware, you’re free to contribute to any La Suite project, let's see the positive side of things. If you’d like, feel free to start a discussion in the La Suite devroom, to challenge the gitmoji, you could raise your voice, and other developers might follow along ;) Regarding your suggestions, please proceed with points 4/5/6/7/8. This landing page is primarily marketing material, updated occasionally when they revise the copywriting. Contributions are, of course, welcome, but the focus is more on structured digital commons like documentation or Grist. |
Purpose
grist.numerique.gouv.fr is officially in beta and should be displayed as is in the landing page.
Proposal
Add a
status: "Beta"
property.