Skip to content

Commit

Permalink
feat: tiny accessibility fixes
Browse files Browse the repository at this point in the history 
Those are micro changes to better match our accessibility standards:

- add the website context in the title
- change link color to match color contrast ratio required by RGAA and
underline links to mark the difference with surrounding text. Chose DSFR
blue
- wrap everything in a <main> tag as nothing should be outside region
tags in theory

I know it's not that necessary on those pages but now they can pass
automated a11y tests if we setup any :)
  • Loading branch information
@manuhabitela
manuhabitela committed Mar 19, 2024
1 parent bcfcab0 commit 88790c3
Showing 1 changed file with 54 additions and 42 deletions.
96 changes: 54 additions & 42 deletions views/index.ejs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="utf-8"/>
<meta name="viewport" content="width=device-width"/>
<title><%= locals.title %></title>
<title><%= locals.title %> - MonComptePro</title>
<style>
.moncomptepro-button {
background-color: transparent !important;
Expand All @@ -20,50 +20,62 @@
}
</style>
<link rel="stylesheet" href="<%= locals.stylesheet_url %>"/>
<style>
:root {
--b-link: #000091;
}
a {
text-decoration: underline;
}
a:hover, a:focus {
text-decoration: none;
}
</style>
</head>
<body>
<h1><%= locals.title %></h1>
<h2>Se connecter</h2>
<div>
<form action="/login" method="post">
<button id="login" class="moncomptepro-button"></button>
<main>
<h1><%= locals.title %></h1>
<h2>Se connecter</h2>
<div>
<form action="/login" method="post">
<button id="login" class="moncomptepro-button" aria-label="S'identifier avec MonComptePro"></button>
</form>
<p>
<a href="https://moncomptepro.beta.gouv.fr/" target="_blank" rel="noopener noreferrer"
title="Qu’est-ce que MonComptePro ? - nouvelle fenêtre">
Qu’est-ce que MonComptePro ?
</a>
</p>
</div>
<% if (locals.userinfo) { %>
<h2>Information utilisateur</h2>
<pre><code><%= locals.userinfo %></code></pre>
<% } %>
<% if (locals.idtoken) { %>
<h2>ID Token</h2>
<pre><code><%= locals.idtoken %></code></pre>
<% } %>
<% if (locals.oauth2token) { %>
<h2>OAuth2 Token</h2>
<pre><code><%= locals.oauth2token %></code></pre>
<% } %>
<h2>Interactions</h2>
<form action="/logout" method="post">
<button id="logout">Se déconnecter</button>
</form>
<br>
<form action="/select-organization" method="post">
<button id="select-organization">Changer d’organisation</button>
</form>
<br>
<form action="/update-userinfo" method="post">
<button id="update-userinfo">Mettre à jour mes informations</button>
</form>
<br>
<form action="/force-login" method="post">
<button id="force-login">Forcer une reconnexion</button>
</form>
<p>
<a href="https://moncomptepro.beta.gouv.fr/" target="_blank" rel="noopener noreferrer"
title="Qu’est-ce que MonComptePro ? - nouvelle fenêtre">
Qu’est-ce que MonComptePro ?
</a>
</p>
</div>
<% if (locals.userinfo) { %>
<h2>Information utilisateur</h2>
<pre><code><%= locals.userinfo %></code></pre>
<% } %>
<% if (locals.idtoken) { %>
<h2>ID Token</h2>
<pre><code><%= locals.idtoken %></code></pre>
<% } %>
<% if (locals.oauth2token) { %>
<h2>OAuth2 Token</h2>
<pre><code><%= locals.oauth2token %></code></pre>
<% } %>
<h2>Interactions</h2>
<form action="/logout" method="post">
<button id="logout">Se déconnecter</button>
</form>
<br>
<form action="/select-organization" method="post">
<button id="select-organization">Changer d’organisation</button>
</form>
<br>
<form action="/update-userinfo" method="post">
<button id="update-userinfo">Mettre à jour mes informations</button>
</form>
<br>
<form action="/force-login" method="post">
<button id="force-login">Forcer une reconnexion</button>
</form>
<br>
</main>
<footer>
<p>Source: <a href="https://github.com/betagouv/moncomptepro-test-client">github.com/betagouv/moncomptepro-test-client</a></p>
</footer>
Expand Down

0 comments on commit 88790c3

Please sign in to comment.