Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tsc): add noPropertyAccessFromIndexSignature option #669

Merged
merged 5 commits into from
Sep 17, 2024
Merged

chore(tsc): add noPropertyAccessFromIndexSignature option #669

merged 5 commits into from
Sep 17, 2024
+56 −23

Conversation

douglasduteil
Copy link
Member

@douglasduteil douglasduteil commented Aug 27, 2024 •
edited
Loading

Requires #677

@douglasduteil douglasduteil added the enhancement New feature or request label Aug 27, 2024
@douglasduteil douglasduteil self-assigned this Aug 27, 2024
@douglasduteil douglasduteil changed the title chore(tsc): add noPropertyAccessFromIndexSignature option @douglasduteil chore(tsc): add noPropertyAccessFromIndexSignature option Aug 27, 2024
@douglasduteil douglasduteil force-pushed the douglasduteil/chore-tsc-add-noPropertyAccessFromIndexSignature-option branch 2 times, most recently from 416feb7 to 7b14a25 Compare August 27, 2024 09:59
@douglasduteil douglasduteil marked this pull request as ready for review August 27, 2024 10:15
@douglasduteil
Copy link
Member Author

🔧 Alignement des règles TypeScript

rdubigny
rdubigny reviewed Aug 28, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/controllers/user/official-contact-email-verification.ts Outdated Show resolved Hide resolved
src/config/env.ts Outdated Show resolved Hide resolved
src/managers/oidc-client.ts Show resolved Hide resolved
rdubigny
rdubigny reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@rdubigny rdubigny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@douglasduteil can't wait to merge this !

A few comments though.

src/controllers/user/official-contact-email-verification.ts Outdated Show resolved Hide resolved
src/controllers/user/official-contact-email-verification.ts Outdated Show resolved Hide resolved
src/types/oidc-provider.ts Outdated Show resolved Hide resolved
This was referenced Aug 30, 2024
Merged
Merged
Merged
@douglasduteil douglasduteil force-pushed the douglasduteil/chore-tsc-add-noPropertyAccessFromIndexSignature-option branch from a353101 to 47713e0 Compare September 3, 2024 10:21
@douglasduteil douglasduteil force-pushed the douglasduteil/chore-tsc-add-noPropertyAccessFromIndexSignature-option branch from 47713e0 to 9416aad Compare September 3, 2024 11:41
@douglasduteil
Copy link
Member Author

It's now require #677 to work

@douglasduteil douglasduteil marked this pull request as draft September 3, 2024 11:48
@douglasduteil douglasduteil marked this pull request as ready for review September 17, 2024 12:17
@rdubigny rdubigny merged commit 7055c32 into master Sep 17, 2024
28 checks passed
@rdubigny rdubigny deleted the douglasduteil/chore-tsc-add-noPropertyAccessFromIndexSignature-option branch September 17, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdubigny rdubigny rdubigny approved these changes

Assignees

@douglasduteil douglasduteil

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglasduteil @rdubigny