Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(env): less variable for devs more variable in prod configura… #685

Merged
merged 3 commits into from
Sep 13, 2024
Merged

refactor(env): less variable for devs more variable in prod configura… #685

merged 3 commits into from
Sep 13, 2024

Conversation

rdubigny
Copy link
Contributor

…tion

@rdubigny
Copy link
Contributor Author

@douglasduteil I have updated scalingo env already.

@rdubigny
Copy link
Contributor Author

Next steps on this :

  • rename all feature toggling env var positively. For example, "DO_NOT_SEND_MAIL" becomes "FEATURE_SEND_MAIL".
  • use docker-compose.yml in end-to-end.tml instead of describing testing environnement twice.

@rdubigny rdubigny merged commit 4358307 into master Sep 13, 2024
28 checks passed
@rdubigny rdubigny deleted the dev-first-env-var branch September 13, 2024 11:03
@rdubigny rdubigny mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglasduteil douglasduteil douglasduteil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdubigny @douglasduteil