feat(front): update website with new mockup #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rebeccadumazert
commented
Aug 13, 2024
•
rebeccadumazert
commented
|
@rebeccadumazert Is it really a modal ? |
|
[Sry miss laptop click 🫢 ] |
rebeccadumazert
force-pushed
the
RDUM-update-website
branch
2 times, most recently
from
b021bc1
to
9437793
Compare
rebeccadumazert
force-pushed
the
RDUM-update-website
branch
from
9437793
to
3df0ed5
Compare
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| {/* <Element name="componentStart"> |
There was a problem hiding this comment.
Est-ce qu'on peut supprimer tous les commentaires dans ce composant ?
There was a problem hiding this comment.
c'est une PR que je vais faire après avoir mergée celle-ci. Il y a plein plein de commentaires dans le code qui datent de la première version proconnect. J'attends de mergée cette PR pour tout cleaner, je voulais pas mélanger ces deux tâches qui sont distinctes l'une de l'autre, si c'est ok pour toi
src/Pages/PrivateProfessional.tsx
Outdated
| @@ -1,4 +1,4 @@ | |||
| import PrivateOrPublic from '../components/PrivateOrPublic/PrivateOrPublic'; | |||
| import PrivateOrPublic from '../components/HowDoesItWork/HowDoesItWork'; | |||
There was a problem hiding this comment.
Faut renommer l'import du composant ici
There was a problem hiding this comment.
c'était carrément un composant qu'il fallait supprimer, je l'ai supprimé 🙏🏻
rebeccadumazert
force-pushed
the
RDUM-update-website
branch
from
3df0ed5
to
1f24d2f
Compare
BenoitSerrano
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.