-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[T6A1][W10-B4]Li Zihan #407
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ | |
import seedu.addressbook.data.AddressBook; | ||
import seedu.addressbook.data.person.ReadOnlyPerson; | ||
import seedu.addressbook.parser.Parser; | ||
import seedu.addressbook.storage.Storage; | ||
import seedu.addressbook.storage.StorageFile; | ||
|
||
import java.util.Collections; | ||
|
@@ -17,7 +18,7 @@ | |
public class Logic { | ||
|
||
|
||
private StorageFile storage; | ||
private Storage storage; | ||
private AddressBook addressBook; | ||
|
||
/** The list of person shown to the user most recently. */ | ||
|
@@ -28,28 +29,28 @@ public Logic() throws Exception{ | |
setAddressBook(storage.load()); | ||
} | ||
|
||
Logic(StorageFile storageFile, AddressBook addressBook){ | ||
setStorage(storageFile); | ||
Logic(Storage storage, AddressBook addressBook){ | ||
setStorage(storage); | ||
setAddressBook(addressBook); | ||
} | ||
|
||
void setStorage(StorageFile storage){ | ||
this.storage = storage; | ||
void setStorage(Storage storage2){ | ||
this.storage = storage2; | ||
} | ||
|
||
void setAddressBook(AddressBook addressBook){ | ||
this.addressBook = addressBook; | ||
} | ||
|
||
/** | ||
* Creates the StorageFile object based on the user specified path (if any) or the default storage path. | ||
* @throws StorageFile.InvalidStorageFilePathException if the target file path is incorrect. | ||
* Creates the Storage object based on the user specified path (if any) or the default storage path. | ||
* @throws Storage.InvalidStorageFilePathException if the target file path is incorrect. | ||
*/ | ||
private StorageFile initializeStorage() throws StorageFile.InvalidStorageFilePathException { | ||
private Storage initializeStorage() throws StorageFile.InvalidStorageFilePathException { | ||
return new StorageFile(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Good job applying DIP. The creating of |
||
} | ||
|
||
public String getStorageFilePath() { | ||
public String getStoragePath() { | ||
return storage.getPath(); | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package seedu.addressbook.storage; | ||
|
||
import seedu.addressbook.data.AddressBook; | ||
import seedu.addressbook.storage.StorageFile.StorageOperationException; | ||
|
||
public abstract class Storage { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Header comment? You should also include the two exception handling implementations here. |
||
|
||
public abstract void save(AddressBook addressBook) throws StorageOperationException; | ||
public abstract AddressBook load() throws StorageOperationException; | ||
public abstract String getPath(); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package seedu.addressbook.storage; | ||
|
||
import seedu.addressbook.data.AddressBook; | ||
import seedu.addressbook.storage.StorageFile.StorageOperationException; | ||
|
||
public class StorageStub extends Storage { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Better to have this in the |
||
|
||
private String path; | ||
|
||
public StorageStub(String path) { | ||
this.path = path; | ||
} | ||
|
||
@Override | ||
public void save(AddressBook addressBook) throws StorageOperationException {} | ||
|
||
@Override | ||
public AddressBook load() throws StorageOperationException { | ||
return null; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
@Override | ||
public String getPath() { | ||
return path; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the same variable name?