Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T4A1][T01-T1]Rahumathmarini #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marini-rahumath
Copy link

…class

@marini-rahumath marini-rahumath changed the title [T4A1][T1-01]Rahumathmarini [T4A1][T01-T1]Rahumathmarini Jul 3, 2017
@@ -56,4 +56,10 @@ public int hashCode() {
public boolean isPrivate() {
return isPrivate;
}

@Override

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation problem here? Our coding standard requires you to use 4 spaces instead of tabs. You can configure Eclipse to convert tabs to spaces automatically.

@@ -0,0 +1,5 @@
package seedu.addressbook.data.person;

public interface Printable {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing header comment. All non-trivial classes and methods should have javadoc format header comments.

@nishantbudhdev
Copy link

@marini-rahumath Some comments added. Please close the PR after reading them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants