[T4A1][T1-04] Aung Swumm #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added interface "Printable" and overrides in detail classes
| @@ -0,0 +1,14 @@ | |||
| package seedu.addressbook.data.person; | |||
|
|
|||
| //an interface that allows user to access data on a read-only, immutable basis | |||
There was a problem hiding this comment.
Good that you write the header comment, but try to follow the coding standard for this. Check out ReadOnlyPerson interface for reference.
| for (Printable _printable : printables) { | ||
| printableString.append(_printable.getPrintableString()); | ||
| } | ||
| return printableString.toString(); |
There was a problem hiding this comment.
This code shouldn't be here and also this method is never called. Discuss with your teammates.
| @@ -42,6 +42,11 @@ public String toString() { | |||
| } | |||
|
|
|||
| @Override | |||
| public String getPrintableString() { | |||
| return "Address: " + this.toString(); | |||
| } | |||
There was a problem hiding this comment.
Shouldn't you check whether it's private or not? When do you combine all the printables?
|
@ashpa Some comments added. Please close the PR after reading comments. Clean PR, good job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.