T4A2][T01-T1]Wong Kai Min Herman #115
Conversation
hermanwongkm
commented
Jul 3, 2017
hermanwongkm
commented
|
|
||
| import java.util.ArrayList; | ||
|
|
||
| public class Tagging { |
There was a problem hiding this comment.
Missing header comment. All non-trivial classes and methods should have javadoc format header comments.
| for(String tag : tags){ | ||
| tagString += ("tag" + "\n") ; | ||
| } | ||
| return tagString; |
There was a problem hiding this comment.
Indentation problem here? Our coding standard requires you to use 4 spaces instead of tabs. You can configure Eclipse to convert tabs to spaces automatically.
| import java.util.ArrayList; | ||
|
|
||
| public class Tagging { | ||
| ArrayList<String> tags; |
There was a problem hiding this comment.
Recollect the discussion during tutorial on why this is not the right place to maintain the tagging list. Please check and differentiate the 2 diagrams in the activity description for better understanding
|
@InspiredAlpaca Also you need to print the tags when the session ends! There is no such call to the |
