[T4A2][T01-3] Teo Shu Qi #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return new CommandResult(MESSAGE_EXIT_ACKNOWEDGEMENT); | ||
| } | ||
|
|
||
| public static boolean isExit(Command command) { | ||
| return command instanceof ExitCommand; // instanceof returns false if it is null | ||
| } | ||
|
|
||
| /** | ||
| * Print list of tags added or deleted each person |
| for ( Tagging tagging : allTagging) { | ||
| System.out.println(tagging.toString()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Good job for writing this method.
| */ | ||
| public void printTagging() { | ||
| ArrayList<Tagging> allTagging = addressBook.getAllTagging(); | ||
| for ( Tagging tagging : allTagging) { |
| @@ -24,13 +26,15 @@ | |||
|
|
|||
| private final UniquePersonList allPersons; | |||
| private final UniqueTagList allTags; // can contain tags not attached to any person | |||
| private ArrayList<Tagging> allTagging; | |||
There was a problem hiding this comment.
Good job for creating the Tagging list here.
| /** | ||
| * Update Tags added for each person | ||
| * @param tag | ||
| * @param person |
There was a problem hiding this comment.
Better write a short description for each @param
| @@ -120,6 +141,12 @@ public UniquePersonList getAllPersons() { | |||
| public UniqueTagList getAllTags() { | |||
| return new UniqueTagList(allTags); | |||
| } | |||
| /** | |||
| * Returns a new ArrayList of all Tagging in the address book at the time if the call | |||
There was a problem hiding this comment.
Returns latest tagging list or something similar to that is suffice alrady.
| import seedu.addressbook.data.person.ReadOnlyPerson; | ||
|
|
||
| /** | ||
| * Association class representing an addition/deletion of Tags for the person |
There was a problem hiding this comment.
A more precise description is Represents an adding or removing a Tag to/from a Person.
| private ReadOnlyPerson person; | ||
| private String personName; | ||
|
|
||
| public Tagging(Tag tag, String action, ReadOnlyPerson person2) { |
There was a problem hiding this comment.
what is person2? you better use person
|
|
||
| public Tagging(Tag tag, String action, ReadOnlyPerson person2) { | ||
| this.tag = tag; | ||
| this.action = action; |
There was a problem hiding this comment.
Better create different method for adding/removing a tag.
|
@teoshuqi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.