[T4A1][T01-T3] Teo Shu Qi #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| public String getPrintableString() { | ||
| return LABEL + this.toString(); | ||
| } |
There was a problem hiding this comment.
Shouldn't you check if it's a private or not? The variable name LABEL is too generic.
| @@ -83,5 +83,22 @@ public int hashCode() { | |||
| public String toString() { | |||
| return getAsTextShowAll(); | |||
| } | |||
|
|
|||
| private String addDetailToDetailsString(String details, String detail) { | |||
There was a problem hiding this comment.
No need to create a new method for this. Also the method name is quite confusing. :)
| */ | ||
| private String getPrintableString(Printable ... printable) { | ||
| String details = ""; | ||
| for ( Printable detail :printable) { |
There was a problem hiding this comment.
Pay attention to the white space.
| private String getPrintableString(Printable ... printable) { | ||
| String details = ""; | ||
| for ( Printable detail :printable) { | ||
| addDetailToDetailsString(details, detail.getPrintableString()); |
There was a problem hiding this comment.
You might use java collection method, like String.join or StringBuilder.
| } | ||
|
|
||
| /** | ||
| * Print out the details of the person requested. |
There was a problem hiding this comment.
This method doesn't print anything.
| /** | ||
| * Print out the details of the person requested. | ||
| * @param printable | ||
| * @return a concatenated version of the printable strings of each object. |
There was a problem hiding this comment.
You can remove @return and write Returns ... as the description.
| public interface Printable { | ||
|
|
||
| // Label stating what detail is this detail (e.g. Phone: ) | ||
| public static String LABEL = ""; |
|
@teoshuqi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.