[T5A1][T01-T4] Li Shicheng #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,7 +85,8 @@ public CommandResult execute(String userCommandText) throws Exception { | |||
| private CommandResult execute(Command command) throws Exception { | |||
| command.setData(addressBook, lastShownList); | |||
| CommandResult result = command.execute(); | |||
| storage.save(addressBook); | |||
| if (command.isMutating()) | |||
| storage.save(addressBook); | |||
There was a problem hiding this comment.
The behavior of the code has been changed. Ensure the header comment and the tests have been updated.
Coding standard violation.
| @@ -65,4 +65,9 @@ public int getTargetIndex() { | |||
| public void setTargetIndex(int targetIndex) { | |||
| this.targetIndex = targetIndex; | |||
| } | |||
|
|
|||
| /* | |||
| * Returns whether the given command will change the data. | |||
There was a problem hiding this comment.
It is better to mention it returns true if the Command potentially mutates the data (header comments specify a contract, so try to be as precise as possible). E.g. Adding a duplicate person will not mutate data but the corresponding AddCommand object will still return true for this method.
|
@Li-Shicheng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.