Fix table of contents generation for release notes #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] fixed typo: `table-of-content` in the backreference - [x] missing sanitization of `_`,`+`,`.`,`?` - [ ] handling the confusion of h1 `#` and comment `#`
It seems to suffice to use `str downcase` followed by `str kebab-case` to arrive at the same behavior as the markdown anchor generation. Using `str downcase` before ensures that CamelCase doesn't get converted erroneously.
|
For the h1 vs comment confusion, maybe we can just hardcode the whitelist of expected h1s? |
|
Yeah I was thinking of whitelist plus a |
|
pr 1000, nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
table-of-contentin the backreference_,+,.,?#and comment#