Port before_v0.60/coloring folder (issue #221)
#836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like there are some conflicts here |
This script is already ported to `modules/coloring/24bit-1.nu`
This script is already ported to `modules/coloring/256_color_testpattern.nu`
- `str lpad` -> `fill -a l`
- `if {}{}` -> `if {} else {}`
- `str collect` -> `str join`
- explicit `print`
- `str collect` -> `str join` - remove the commented old script for 0.31 - pipeline for -> `each` - escape `\`
- remove the version comment - `str collect` -> `str join` - remove `autoview`
- math eval % to `mod`
- `str collect` -> `str join`
- `if {} {}` -> `if {} else {}`
- merge `nu_index_fg.nu` and `nu_index_fg2.nu` this is the same script
- math eval % to `mod`
- `str lpad -l` to `fill -a l -w`
- `str collect` -> `str join`
- `if {} {}` -> `if {} else {}`
- uncomment one-liner, make a function
- `str collect` -> `str join`
- `str lpad -l` -> `fill -a l -w`
- `if {...} {<empty>}` -> `if {}`
- explicit print
- `str collect` -> `str join` - explicit print - `str lpad -l` -> `fill -a l -w`
- `str collect` -> `str join`
- remove autoview
- `echo 40..47 100..107 49` -> `[40..47 100..107 49] | each { flatten } | flatten`
I've pasted them inside nu scripts
39555
force-pushed
the
port-before_v0.60/coloring
branch
from
ef22f0f to
917abad
Compare
|
I updated my fork and rebased my branch. Conflicts were due deletion |
|
Oh, I had those files there for a reason when I wrote them. It's good to see what the bash/pwsh/python equivalent is when porting a script. Maybe we should add them back. |
I put them in comments in nu files. Some nu scripts has already contain bash equivalents in comments so I decided it is convenient. If they should be separated files, I can revert it and just move to new location |
|
oh, I'm fine with comments. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of porting all old scripts #221 and ports
coloringfolder