Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda activate should expand $env.PATH to a connection of absolute paths #998

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

WindSoilder
Copy link
Contributor

@WindSoilder WindSoilder commented Dec 19, 2024

Noticed an issue in conda.nu.

It modified $env.PATH from list of string to a string, without expanding it. It may be a problem if I have a path which is relative:

$env.PATH = ($env.PATH | split row (char esep) | prepend '~/.cargo/bin')

After activating an env, it's impossible to find executables in ~/.cargo/bin. So this pr is going to make sure the path is expanded while converting.

For more context: nushell/nushell#14615

@WindSoilder WindSoilder marked this pull request as draft December 19, 2024 01:40
@WindSoilder WindSoilder marked this pull request as ready for review December 19, 2024 03:26
@fdncred fdncred merged commit be6411e into main Dec 19, 2024
1 check passed
@fdncred
Copy link
Collaborator

fdncred commented Dec 19, 2024

Thanks

@fdncred fdncred deleted the conda branch December 19, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants