✨ add a Contributing guide to parser and editor tools related stuff #1311
Conversation
|
Good! Ready to run the CI and one final review |
| We have another grammar: [tree-sitter nushell](https://github.com/nushell/tree-sitter-nu) this is useful for terminal text editors (nvim, helix, etc). VS Code doesn't have support for tree-sitter and its grammar [is written in tmLanguage](https://github.com/nushell/vscode-nushell-lang/blob/main/syntaxes/nushell.tmLanguage.json) | ||
| It has the following goals: | ||
|
|
||
| - Ability to serve as a parser for a repl |
There was a problem hiding this comment.
I would strike that line as this is probably misleading as it is not used in our repl.
There was a problem hiding this comment.
it's from the tree-sitter-nu's readme. Would you recommend deleting line 65 in both cases?
There was a problem hiding this comment.
Hi! Did you have time to review this 😄 ? Thanks!
|
fixed the typos CI 😄 , can I have a workflow approval? 👍🏼 |
|
|
||
| - hover | ||
| - go to definition | ||
| - auto-completions |
There was a problem hiding this comment.
There are a few things missing from this list.
It also helps locate nu and if it finds it allow nu to be used as a terminal shell.
It displays Inlays
It allows you to have separate IncludeDirs
It has diagnostics to show errors
Most of this is laid out in the extension readme
As said in discord, I would like to make an introductory document on everything that is related to the parser and other editor tools (tree-sitter, nufmt, both LSPs, etc).
I think there is a load of knowledge that it'd be cool to write it down to see where we are, and also to point out people who have questions.
Also, if new people want to join, there is some knowledge required to understand what is going on
link to markdown rendered document