-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace crossterm ScrollUp with universal workaround #601
Conversation
Replace scrolling via escape sequence with workaround that prints newlines to retain scrollback regardless of terminal implementation of scroll sequence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving this!
This sounds reasonable and your helper is amazingly documented.
Love it! Nice work @NotLebedev! |
@NotLebedev I'm seeing missing lines in Windows Terminal but seemingly only when maximized.
produces this problem on the first example.
The top of the table is cutoff and it's the very first line. |
Is master branch (or your branch) of nushell using this patch? It seems like at least master does not. Here in |
rebuilding on latest main to make sure. stay tuned. |
I think you're right @NotLebedev. I got the latest main, checkout the detect columns pr, merged main, then did cargo update -p reedline and now my reedline is on 4f31e. I missed doing the cargo update last time so my mistake. It's working great now. Sorry for the false alarm! |
Replace scrolling via escape sequence with workaround that prints newlines to retain scrollback regardless of terminal implementation of scroll sequence. See nushell/9166 for discussion and related info.
This PR replaces using ScrollUp sequence
"\[e<num>S"
with printing desired amount of blank lines at the last line of terminal window. This workaround functions on all terminals that have scrollback buffer regardless of their ability to handle and implementation of ScrollUp sequence.