New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to read if file doesn't exist #143

Merged

fdncred merged 2 commits into nushell:main from gaetschwartz:proper-error-handling-goto-def-no-file

Jul 25, 2023

Contributor

gaetschwartz commented Jul 10, 2023

At least fixes the error in #134 , but not the actual reason why nu returns "file" : "source" sometimes.

gaetschwartz and others added 2 commits

July 10, 2023 12:37


          Don't try to read if file doesn't exist (nushell#134)

6915ebb


          Merge branch 'main' into proper-error-handling-goto-def-no-file

0e1752f

Collaborator

fdncred commented Jul 25, 2023

JT helped me understand that source is a sentinel value. So, I think it's ok to land this and just ignore it.

fdncred merged commit fcedfc0 into nushell:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet