Skip to content

Commit

Permalink
Squash into docs commit
Browse files Browse the repository at this point in the history
Co-authored-by: Daira Emma Hopwood <[email protected]>
  • Loading branch information
str4d and daira authored Jul 18, 2023
1 parent 6b1bb94 commit fce4447
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions zcash_client_sqlite/src/wallet/scanning.rs
Original file line number Diff line number Diff line change
Expand Up @@ -319,10 +319,11 @@ impl SpanningTree {
match self {
SpanningTree::Leaf(cur) => Self::from_joined(insert(cur, to_insert)),
SpanningTree::Parent { span, left, right } => {
// TODO: this algorithm always preserves the existing partition point, and does not
// do any rebalancing or unification of ranges within the tree; `into_vec`
// performs such unification, and the tree being unbalanced should be fine given
// the relatively small number of ranges we should ordinarily be concerned with.
// This algorithm always preserves the existing partition point, and does not do
// any rebalancing or unification of ranges within the tree. This should be okay
// because `into_vec` performs such unification, and the tree being unbalanced
// should be fine given the relatively small number of ranges we should ordinarily
// be concerned with.
use RangeOrdering::*;
match RangeOrdering::cmp(&span, to_insert.block_range()) {
LeftFirstDisjoint => {
Expand Down Expand Up @@ -566,7 +567,7 @@ pub(crate) fn scan_complete<P: consensus::Parameters>(
.flatten())
};

// if no notes belonging to the wallet were found, we don't need to extend the scanning
// If no notes belonging to the wallet were found, we don't need to extend the scanning
// range suggestions to include the associated subtrees, and our bounds are just the
// scanned range.
subtree_bounds
Expand Down

0 comments on commit fce4447

Please sign in to comment.