Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: messages type generation not watching locale files #3224

Conversation

BobbieGoede
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This has not been tested with restructureDir: false, I expect it might trigger generation twice πŸ€”

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Nov 13, 2024
Copy link

pkg-pr-new bot commented Nov 13, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@nuxtjs/i18n@3224

commit: 870caaf

@BobbieGoede BobbieGoede force-pushed the fix/messages-type-generation-watch-locale-files branch from 619f6f7 to 0913d62 Compare November 14, 2024 14:59
@BobbieGoede BobbieGoede changed the title [DRAFT] fix: messages type generation not watching locale files fix: messages type generation not watching locale files Nov 14, 2024
@BobbieGoede
Copy link
Collaborator Author

This relies on chokidar being installed (nuxt uses it too), should chokidar be added to dependencies or devDependencies? What do you think @userquin

@BobbieGoede BobbieGoede merged commit c0532a9 into nuxt-modules:main Nov 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant